Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add discord-formatted export support #5533

Merged
merged 2 commits into from
Jun 1, 2024

Conversation

pavelbraginskiy
Copy link
Collaborator

No description provided.

@pavelbraginskiy
Copy link
Collaborator Author

MegaMek component of MegaMek/megameklab#1517

}
if (colors.containsKey(r)) {
try {
var ignored = DiscordFormat.valueOf(colors.get(r).toUpperCase()).format();

Check notice

Code scanning / CodeQL

Unread local variable Note

Variable 'String ignored' is never read.
Copy link
Member

@SJuliez SJuliez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. I have some rather minor comments. I'll approve this and still be happy if you could address them (changing the enums willl affect the MML PR too).

megamek/src/megamek/common/util/DiscordExportUtil.java Outdated Show resolved Hide resolved
megamek/src/megamek/common/MechView.java Outdated Show resolved Hide resolved
@pavelbraginskiy
Copy link
Collaborator Author

@SJuliez Done!

@SJuliez SJuliez merged commit 1a6ec1e into MegaMek:master Jun 1, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants